Icebob

Results 390 comments of Icebob

please merge changes from the master, some test is not up-to-date.

It's an old module, it is not used in the library anymore. But somehow this PR affects the `async_hooks` if the unit test failed, but in the master it doesn't.

@ngraef I see, I don't forget it, but I'm hesitating because it contains a lot of changes affecting the tracer, context, and the communication protocol. I don't feel it can...

what do you think about it? https://github.com/DataDog/dd-trace-js/pull/1598

OK. _In the next major release, we should refactor it and pass only `ctx`, and `opts` only instead of many parameters._

@elixiao what is your use-case why you are using sealed objects?

Please create a repro repo and I will check what we can do to solve it.

Yeah, good idea. But in a separated repo.

It's normal because the whole root `payload` object is missing, so no field value.