BREAKING CHANGE: use ibis.common.Graph() instead of util.to_op_dag(); use graph.toposort() instead of util.toposort(); use ibis.common.annotations module instead of ibis.common.validators

Test Results

       6 files         6 suites   4m 3s :stopwatch: 3 207 tests 3 193 :heavy_check_mark: 14 :zzz: 0 :x: 9 594 runs  9 552 :heavy_check_mark: 42 :zzz: 0 :x:

Results for commit 458fb120.

:recycle: This comment has been updated with latest results.

Codecov Report

Merging #4552 (458fb12) into master (588df3f) will increase coverage by 0.06%. The diff coverage is 97.42%.

@@            Coverage Diff             @@
##           master    #4552      +/-   ##
==========================================
+ Coverage   92.34%   92.41%   +0.06%     
==========================================
  Files         183      185       +2     
  Lines       20024    20185     +161     
  Branches     2966     3001      +35     
==========================================
+ Hits        18492    18653     +161     
- Misses       1151     1155       +4     
+ Partials      381      377       -4     

Impacted Files	Coverage Δ
ibis/util.py	62.11% <54.54%> (-4.93%)	:arrow_down:
ibis/backends/dask/execution/util.py	87.06% <80.00%> (ø)
ibis/common/graph.py	95.55% <95.55%> (ø)
ibis/expr/analysis.py	95.52% <95.65%> (-0.03%)	:arrow_down:
ibis/common/validators.py	99.06% <97.56%> (+4.28%)	:arrow_up:
ibis/backends/base/sql/__init__.py	89.10% <100.00%> (ø)
ibis/backends/base/sql/compiler/select_builder.py	97.32% <100.00%> (+0.01%)	:arrow_up:
ibis/backends/clickhouse/__init__.py	91.00% <100.00%> (-0.09%)	:arrow_down:
ibis/backends/impala/__init__.py	86.11% <100.00%> (+0.21%)	:arrow_up:
ibis/backends/pandas/__init__.py	84.90% <100.00%> (-0.15%)	:arrow_down:
... and 28 more

@kszucs Can you squash? Will merge after that!

@cpcloud it requires another review

@cpcloud it requires another review

Got it.

What's the breaking change here? APIs in ibis.util are not guaranteed to be backwards compatible even if they are public.

@cpcloud it requires another review

Got it.

What's the breaking change here? APIs in ibis.util are not guaranteed to be backwards compatible even if they are public.

I removed the breaking change note from the commit then.

@cpcloud it's green