dayjs icon indicating copy to clipboard operation
dayjs copied to clipboard

Published 20 hours ago • verified publisher icon iamkun

Use numerals in relative time formatter in FI locale

Open sergioisidoro opened this issue 1 year ago • 4 comments

Fixes https://github.com/iamkun/dayjs/issues/2589

sergioisidoro avatar Feb 23 '24 14:02 sergioisidoro

Sorry, I am not a native speaker, and just wondering if it would be better if we follow https://github.com/moment/moment/blob/develop/src/locale/fi.js?

iamkun avatar Apr 27 '24 18:04 iamkun

Hi @iamkun thanks for taking the time to check this out.

Did you have the chance to read my rationale in the issue? I tried to explain the reason for this proposal there.

sergioisidoro avatar Apr 27 '24 21:04 sergioisidoro

Thanks for the PR as well as the relative issue.

I've read the editorial and the solution, however, maybe I am not the one who can make the decision.

It will be better to keep this PR open until some native speakers review it, or just keep the same with moment.js at present, which is safer.

iamkun avatar Apr 28 '24 16:04 iamkun

That sounds very reasonable :) Just as a contextual information - I'm not native, but I've been living in Finland for 10 years, and I have consulted with a native speaker before making this proposal. But I think it makes sense to wait for a second opinion.

sergioisidoro avatar Apr 29 '24 06:04 sergioisidoro