dayjs icon indicating copy to clipboard operation
dayjs copied to clipboard

fix: wrong ordinal for french locale

Open ctessier opened this issue 3 years ago • 1 comments

In french, when writing dates, there is no ordinal for numbers over 1.

  • lundi 1er août 2022 :heavy_check_mark:
  • jeudi 11 août 2022 :heavy_check_mark:
  • jeudi 11e août 2022 :x:

In other contexts, this could be correct, but not for dates. See for instance on this French website of the government : https://www.service-public.fr/particuliers/actualites

ctessier avatar Aug 04 '22 13:08 ctessier

For more context: this is basically a revert of the regression introduced by this PR https://github.com/iamkun/dayjs/pull/1932 in the v1.11.4

xavier-villelegier avatar Aug 05 '22 13:08 xavier-villelegier

Codecov Report

Merging #2010 (3d84e16) into dev (b5b7be1) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev     #2010   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          181       181           
  Lines         2074      2074           
  Branches       544       544           
=========================================
  Hits          2074      2074           
Impacted Files Coverage Δ
src/locale/fr.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 12 '22 12:08 codecov[bot]

Thanks, let's get it to revert to the original one

iamkun avatar Aug 12 '22 12:08 iamkun

:tada: This PR is included in version 1.11.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

iamkun avatar Aug 12 '22 12:08 iamkun