trakt-scrobbler icon indicating copy to clipboard operation
trakt-scrobbler copied to clipboard

[RFE] Release with github-actions

Open ahmubashshir opened this issue 3 years ago • 10 comments

We can do this in a 2(or more, if anyone has other methods) ways:

  1. Manually creating the release, steps:
    1. Bump version in pyproject.toml
    2. Commit, tag, push
    3. Create release
    4. Run poetry publish in workflow
  2. Publishing release from tag, steps:
    1. Bump version in pyproject.toml
    2. Commit, tag, push
    3. Create release and poetry publish in workflow

ahmubashshir avatar Mar 01 '22 16:03 ahmubashshir

Yeah, there's been a ~minor~ major hitch in this. Apparently, I set up 2FA for my PyPI account some time ago, and there's been a few mobile device changes since then. I don't see the site in my 2FA app, and PyPI says I haven't set up any recovery codes either. So I'm essentially locked out of my account :)

It's really weird though, I don't remember setting up 2FA on there. And if I did, I would have made sure to store the recovery codes in my password manager. Not sure what happened there.

Seems like I'm gonna have to abandon the account on PyPI :/

Edit: Ah, looks like there's a way to resolve this https://github.com/pypa/pypi-support That's nice :)

iamkroot avatar Mar 02 '22 12:03 iamkroot

BTW, you can test the workflow with nektos/act.

Required files:

// event.json
{
   "ref": "refs/tags/v1.4.2"
}
# .secrets
PYPI_TOKEN="<PYPI_API_TOKEN>"

then run act -e event.json to test the workflow.

ahmubashshir avatar Mar 03 '22 02:03 ahmubashshir

Should we also add the aur release to the work flow?

iamkroot avatar Mar 07 '22 17:03 iamkroot

Nope, because we'll have to setup an archlinux container to do that. I'll add auto-updater to pkgbuilds after my uni admission.

P.S. Did you test the action?

ahmubashshir avatar Mar 07 '22 18:03 ahmubashshir

we'll have to setup an archlinux container to do that.

Ah right, hadn't thought it through.

P.S. Did you test the action?

Not yet, will try to get it done by this week. I guess it should be straightforward though - uploading to PyPI is simple. Plus I'm still waiting on the account recovery request, so won't be able to deploy for now.

iamkroot avatar Mar 08 '22 18:03 iamkroot

Ah right, hadn't thought it through.

I'll do that in my pkgbuilds repo, as all workflows there uses archlinux container. ETA 3 months, after my uni admission...

ahmubashshir avatar Mar 08 '22 18:03 ahmubashshir

How's the situation with pypi now?

ahmubashshir avatar May 14 '22 12:05 ahmubashshir

Sadly, no response from their team ;-;

iamkroot avatar May 15 '22 04:05 iamkroot

Any update from them?

ahmubashshir avatar Aug 02 '22 13:08 ahmubashshir

Nope, they haven't replied to any request since March. Will have to wait and see.

iamkroot avatar Aug 02 '22 13:08 iamkroot

Hey @ahmubashshir finally got the account 2FA reset. Will try testing your PR with act first

iamkroot avatar Oct 22 '22 12:10 iamkroot