Conversations icon indicating copy to clipboard operation
Conversations copied to clipboard

Missed call notifications

Open dmitry-markin opened this issue 5 years ago • 6 comments

Hope this may be helpful

dmitry-markin avatar Aug 09 '20 10:08 dmitry-markin

@iNPUTmice will this PR ever be considered? Being honest, not the PR itself but the feature is something quite simple and useful to be simply ignored.

JetpackDuba avatar Mar 04 '21 16:03 JetpackDuba

@iNPUTmice will this PR ever be considered? Being honest, not the PR itself but the feature is something quite simple and useful to be simply ignored.

I agree, this feature is really useful, if I may vote this PR, please consider it. Thanks.

satarsa avatar Mar 22 '21 09:03 satarsa

Thank you Dmitry, works for me fine after rebase! I'm not Conversations developer, but I do appreciate this effort. Would you be able to rebase? Perhaps after that the developers would consider this PR?

jmencak avatar Jul 04 '21 13:07 jmencak

So this has been done 2 years ago and still not merged? How can one even consider a calling app without a missed call notification to be in any way finished? Is there a fork of conversations with essential features like this one add to it?

chpio avatar Feb 06 '22 11:02 chpio

So this has been done 2 years ago and still not merged?

It is not exactly surprising. The PR had no (official) review and what contributor wants to contribute/update their PRs when they are treated like this. To defend the main developer though, he's doing a fantastic job and perhaps this just slipped through his fingers. What is mind-boggling though, https://github.com/iNPUTmice/Conversations/issues/4122 being closed without any comment whatsoever.

Is there a fork of conversations with essential features like this one add to it?

I'm not aware of one. But of course, you're free to fork. Personally, I just keep updating conversations and adjusting this patch not to conflict. But yeah, it is extra work, therefore annoying. :)

jmencak avatar Feb 06 '22 17:02 jmencak

Since the patches are very old there are merge conflicts. I resolved the merge conflicts on my branch. Maybe a maintainer can check it out this time, so the PR no longer needs to stall.

emankced avatar Apr 11 '22 12:04 emankced