react-i18next

react-i18next copied to clipboard

Dependent on https://github.com/i18next/i18next/pull/1775

We'll no longer support typescript below v4.1

Checklist

• [x] only relevant code is changed (make a diff before you submit the PR)
• [ ] run tests npm run test
• [ ] tests are included

Checklist (for documentation change)

• [ ] only relevant documentation part is changed (make a diff before you submit the PR)
• [ ] motivation/reason is provided

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Bump, not stale! @pedrodurek what is blocking on this PR? Is there something I can do to help push it along?

For context the issue we are facing is the following, and going on the title of this PR it should fix the issue we are seeing.

I believe this is good to go. I'll leave a request change to bump the minimum i18next once i18next/i18next#1775 is released.

Thank you @pedrodurek

v22.0.0 is now published

@pedrodurek let me know when this can be merged

Coverage remained the same at 95.862% when pulling ad82365b098b8ef964e5cca8dd8a3d0a104eee09 on pedrodurek:make-translation-type-safe into a0eed42303bda4863a832cbd8b280d04448f2690 on i18next:master.

Hey @adrai, this is good now. It needs to be a Major release.

Later today (my timezone 😛), I'll update the react-i18next doc adding a reference to the i18next doc.

@rosskevin as soon as you approve, I'll create a new major version...

btw: in case you're interested: https://github.com/i18next/next-i18next/pull/1966

Thank you for your contributions... v12.0.0 has just been published.

Incredible; thank you all so much for such a quick turnaround! 😍