react-tags

react-tags copied to clipboard

Changes to ensure we support Google Chrome on Android, due to limitations around the soft keyboards and KeyboardEvent.key in onKeydown().

Also changes here provide support for the pasting too, without needing to use onPaste event.

Note, code coverage is reduced in this pull, but it is more to get feedback at this point. Will add them back in due course.

Coverage decreased (-4.9%) to 94.527% when pulling 7498d30e7a21999bb970705c2501ff9b49f6c9c9 on ajmas:issue-94-android-chrome into d2770e701bc81be81aca3b1a67bdf1555c079d73 on i-like-robots:master.

Coverage decreased (-4.9%) to 94.527% when pulling 5987cabd57c869a28703c89e1a0a6236797bd374 on ajmas:issue-94-android-chrome into d2770e701bc81be81aca3b1a67bdf1555c079d73 on i-like-robots:master.

Coverage increased (+0.6%) to 100.0% when pulling 6f7e8413f989f26d1c1c339579ba75332167fca7 on ajmas:issue-94-android-chrome into d2770e701bc81be81aca3b1a67bdf1555c079d73 on i-like-robots:master.

Coverage increased (+0.6%) to 100.0% when pulling 6f7e8413f989f26d1c1c339579ba75332167fca7 on ajmas:issue-94-android-chrome into d2770e701bc81be81aca3b1a67bdf1555c079d73 on i-like-robots:master.

Note, there were two three cases where there was no reasonable way of creating proper code coverage, so I opted to exclude them. Let me know if you have any issues with that.

@ajmas wow, good work! This (to me) is quite a bit nicer than the onPaste implementation, and great work covering the edge cases too. I will give this a good test today and let's get it sorted this week as it's dragged on for too long (my fault entirely).

Re. the test coverage @ajmas - I really don't mind, so long as the main features and interface is covered then I'm not bothered about implementation detail being missed.

Coverage increased (+0.6%) to 100.0% when pulling 76696cf2e021a911d07caaa599bb7aaa468ce666 on ajmas:issue-94-android-chrome into d2770e701bc81be81aca3b1a67bdf1555c079d73 on i-like-robots:master.