react-tags icon indicating copy to clipboard operation
react-tags copied to clipboard

Published 20 hours ago • verified publisher icon i-like-robots

auto-select-first-item

Open muthukumarse opened this issue 8 years ago • 10 comments

Made first item auto selected up on context menu suggestion. Also removed condition to avoid lost focus on TAB key when minQueryLength=0

muthukumarse avatar May 01 '17 23:05 muthukumarse

@muthukumarse Looks like you broke the tests. Those will probably need be fixed before this is merged.

Billy- avatar May 02 '17 11:05 Billy-

re #55

Billy- avatar May 02 '17 11:05 Billy-

@Billy Can You mention what is the issue.

muthukumarse avatar May 02 '17 11:05 muthukumarse

The ci tests failed - run them locally or check the logs on Travis (click "Details" next to "Travis CI build failed")

Billy- avatar May 02 '17 12:05 Billy-

Coverage Status

Coverage remained the same at 100.0% when pulling 789ba846882526e802a3d2cd803fb135ad51ba90 on muthukumarse:feature/auto-select-first-item into f518186c0e2de0560b809ef14b1332ac56be7090 on i-like-robots:master.

coveralls avatar May 02 '17 22:05 coveralls

@Billy- correct the issue PR#74

muthukumarse avatar May 02 '17 22:05 muthukumarse

Thanks for your time implementing this feature @muthukumarse. As mentioned in #55 this feature conflicts with the allowNew option. You're implementation is good so I'll have a think about how to reconcile the two.

i-like-robots avatar May 11 '17 07:05 i-like-robots

👍

muthukumarse avatar May 11 '17 08:05 muthukumarse

@i-like-robots Has there been any progress on this pull request. We would very much enjoy this feature :)

gabrielbhansen avatar Feb 11 '19 08:02 gabrielbhansen

Could we merge this pull request? I'm happy to help it depend on allowNew and fix conflicts.

ghost avatar Feb 13 '20 13:02 ghost

Closing as this feature is now supported in v7.

i-like-robots avatar Jul 16 '23 08:07 i-like-robots