react-tags icon indicating copy to clipboard operation
react-tags copied to clipboard

Published 20 hours ago • verified publisher icon i-like-robots

#259 - full tag to onAddition

Open SebastienDaniel opened this issue 3 years ago • 2 comments

#259 modify onAddition to pass full tag to allow use of additional tag props in custom tagComponent

SebastienDaniel avatar Jan 14 '22 20:01 SebastienDaniel

Coverage Status

Coverage remained the same at 100.0% when pulling 24a653a1c2c3808a273c7873337765463b50175e on zia-ai:main into 9ac82a9879f53d46759dbd559d8b0a99bcd376ae on i-like-robots:main.

coveralls avatar Jan 14 '22 20:01 coveralls

This will be the default behaviour in the next major version (which is in development here).

However, I'm reluctant to make this change to the current version of the component because a change to the public interface should require releasing as a new major version.

i-like-robots avatar Apr 04 '22 10:04 i-like-robots

Was this a breaking change not passing full tag? handleAdd supported this no? Quelle surprise

makis-x avatar Jan 03 '23 08:01 makis-x

Maybe until the new version is released, we could add an additional onAdditionFull event that would pass the full tag without a BC break?

jtojnar avatar Mar 29 '23 16:03 jtojnar

Closing as this feature is now supported in v7.

i-like-robots avatar Jul 16 '23 08:07 i-like-robots