indy-vdr icon indicating copy to clipboard operation
indy-vdr copied to clipboard

feat: updated to fetch 0.4.2 binary

Open wadeking98 opened this issue 1 year ago • 5 comments

Updated the javascript wrappers to use the 0.4.2 binary

wadeking98 avatar May 08 '24 19:05 wadeking98

I’d love to get this into a single branch and to have unified releases of all components at the same time. Additional overhead, but pretty important!

swcurran avatar May 08 '24 20:05 swcurran

@genaris is there an easy way to test it on node and react native? from my understanding it only pulls the binaries when you run npm install from the npm repository.

wadeking98 avatar May 08 '24 22:05 wadeking98

@berendsliedrecht maybe we can also add the example app to this branch so we can more easily test changes in react native?

TimoGlastra avatar May 15 '24 06:05 TimoGlastra

I’d love to get this into a single branch and to have unified releases of all components at the same time. Additional overhead, but pretty important!

I think that makes sense, however it means we will need to require every pull request to implement functionality for all wrappers. It's sometimes quite hard to look in which way a wrapper is outdated, as you have to walk through all commits, see the changes, update it, test the different wrappers, etc..

TimoGlastra avatar May 15 '24 06:05 TimoGlastra

I made some changes to the binary to make it work with react native. For some reason the #[async_trait] macro wasn't working well with react native so I removed it and refactored the code to compensate. I'm going to split up this PR to update the binary and one to update the wrapper

wadeking98 avatar May 15 '24 18:05 wadeking98

I think this PR can be closed right @wadeking98? I made #296 with updates and a new version for the JS wrapper

TimoGlastra avatar Jun 08 '24 09:06 TimoGlastra