aries-acapy-plugin-toolbox

aries-acapy-plugin-toolbox copied to clipboard

did:sov urls changed out for github urls

All of these are referring to tree/master. The Hyperledger project has chosen (from my understanding) to rename all master branches to main. Would you be able to switch all of them to point to main instead of master? Does doing that break anything? The reason why I am asking is because it will ensure that the paths are consistent with the repos themselves and ensure that they work if GitHub decides to ever remove their master->main backwards compatibility for repositories.

Aside from that, I think the change looks good to me. The tests on the other hand seem less convinced.

All of these are referring to tree/master. The Hyperledger project has chosen (from my understanding) to rename all master branches to main. Would you be able to switch all of them to point to main instead of master? Does doing that break anything? The reason why I am asking is because it will ensure that the paths are consistent with the repos themselves and ensure that they work if GitHub decides to ever remove their master->main backwards compatibility for repositories.

You raise some good points. I think if we're in the process of changing these already, it may make sense to coordinate a cut over for this as well. This change may be something we want to raise on the Aries WG call before merging to provide some warning to potential users that this change is taking place and will impact compatibility.

Thoughts on how best to apply these changes, @TelegramSam?

On further consideration, we should make it possible to accept either the old message type or the new message type. This will also ease questions surrounding breaking changes.