kitsu-web icon indicating copy to clipboard operation
kitsu-web copied to clipboard

Replace Canny with Nolt (closes #775)

Open matthewdias opened this issue 5 years ago • 7 comments

👢 🗑️

I've observed an issue here where moment timezone doesn't seem to get imported properly and it breaks the _getCurrentUser method in the application route. Not sure if it's something weird on my end so would appreciate if whoever reviews this could check if that works for them. Dunno if the discussion here is related: https://github.com/hummingbird-me/kitsu-web/pull/775

matthewdias avatar Oct 21 '20 07:10 matthewdias

Thank you for doing this!

toyhammered avatar Oct 21 '20 15:10 toyhammered

SSO (with nolt('identify', { jwt: token })) doesn't seem to happen when logged in on Kitsu

Edit: Nvm, looks like it's calling a query that hasn't been merged/deployed on production

image

wopian avatar Oct 21 '20 18:10 wopian

Ah yep my bad forgot to note it uses this branch. https://github.com/hummingbird-me/kitsu-server/tree/nuck/nolt-sso Will get that updated to relocate the token in the graphql schema

matthewdias avatar Oct 21 '20 19:10 matthewdias

lmk when you've got that branch updated and I can give it 👀 pretty quick

NuckChorris avatar Oct 21 '20 19:10 NuckChorris

LGTM! Don't merge until the server side has been deployed to production yet though - I deploy the-future to production regularly with translation updates

wopian avatar Oct 22 '20 06:10 wopian

Waiting on https://github.com/hummingbird-me/kitsu-server/pull/869

wopian avatar Oct 22 '20 15:10 wopian

Do we want to set up the "remote Login URL" thing? nolt.io/help/single-sign-on

We probably want to do this. The canny integration has started getting spammed by non-Kitsu accounts over the past year which I've had to delete.

wopian avatar Oct 29 '20 01:10 wopian