transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Adding Type Hints to TF_Pegasus model

Open pmollerus23 opened this issue 2 years ago • 3 comments

What does this PR do?

Added type hints for remaining call() functions for the Pegasus model (changes made only in the models/pegasus/modeling_tf_pegasus.py file).

Fixes # (16059)

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case. approval
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

@Rocketknight1

pmollerus23 avatar Mar 03 '23 19:03 pmollerus23

The documentation is not available anymore as the PR was closed or merged.

Hi @mollerup23, mostly looks good! One thing to watch out for is that in some cases the default value of the argument has been changed. It's easy to see if you look in the GitHub "Files changed" tab (see the image - return_dict had its default argument changed) image

If you fix the instances where that happened and double-check that it's all okay in the Files Changed tab, we should be good to go!

Rocketknight1 avatar Mar 06 '23 15:03 Rocketknight1

Hi @Rocketknight1, I updated and committed again. Hopefully these fixes help, let me know if there is anything else I should do!

pmollerus23 avatar Mar 11 '23 00:03 pmollerus23