transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Add TF image classification example script

Open amyeroberts opened this issue 3 years ago • 9 comments

What does this PR do?

Adds the TF equivalent for the PyTorch image classification example script.

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline, Pull Request section?
  • [ ] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

amyeroberts avatar Oct 28 '22 18:10 amyeroberts

The documentation is not available anymore as the PR was closed or merged.

Still no good, I scanned the test fetcher and found a potential bug. COuld you add

            elif f.startswith("examples/tensorflow"):
                test_files_to_run.append("examples/flax/test_tensorflow_examples.py")

at the line 562 of utils/test_fetcher.py (in-between PyTorch and Flax)? I think that's what causing the issue of the tests not running.

sgugger avatar Nov 03 '22 13:11 sgugger

It looks like your branch is a bit old and does not contain some fixes made to make sure the example tests run when an example is modified (you can see the test examples are not running here 😅 ). Could you try a rebase on main?

@sgugger I've rebased from upstream main and force pushed again. If I run git log --oneline I can see these changes are applied on top of the tip of main.

270bfb056 (HEAD -> add-examples-tf-image-classification, origin/add-examples-tf-image-classification) Add tests
a2256258b Fix up
1a1594cb8 Update requirements
b6a2f1ef9 TF image classification script
9ccea7acb (upstream/main, main) Fix some doctests after PR 15775 (#20036)
a639ea9e8 Add **kwargs (#20037)
ec6878f6c Now supporting pathlike in pipelines too. (#20030)
aa39967b2 reorganize glossary (#20010)
305e8718b Show installed libraries and their versions in CI jobs (#20026)

The examples still aren't running and I can't see in the diff where I could be overriding this 😅 I'm sure there's something I'm overlooking. I'll keep digging but let me know if there's something else I should be doing. Sorry to bother.

amyeroberts avatar Nov 03 '22 13:11 amyeroberts

@sgugger - sorry late on the comment as well. I'll add your suggestion!

amyeroberts avatar Nov 03 '22 13:11 amyeroberts

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Nov 29 '22 15:11 github-actions[bot]

Hey @amyeroberts, is this PR still going ahead? It looked almost ready!

Rocketknight1 avatar Dec 02 '22 13:12 Rocketknight1

@Rocketknight1 Yes - sorry, this fell down my priority list for a bit. Code is all ready to go - I was trying to find models that make the tests run quickly c.f. this comment.

amyeroberts avatar Dec 02 '22 19:12 amyeroberts

@amyeroberts Ah, that makes sense! It's totally okay to upload your own super-mini model and use that - it doesn't really matter if the accuracy is bad, the test will just let us detect if the outputs from this model class change suddenly

Rocketknight1 avatar Dec 05 '22 16:12 Rocketknight1

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Dec 30 '22 15:12 github-actions[bot]