Sharding fails in TF when absolute scope was modified if `.` in layer name

Open ArthurZucker opened this issue 3 years ago • 2 comments

What does this PR do?

Fixes #18776, by taking care of the particular case of absolute scope modifications

Sep 20 '22 16:09 ArthurZucker

The documentation is not available anymore as the PR was closed or merged.

Sep 20 '22 17:09 HuggingFaceDocBuilderDev

Do you think we should add a special test for that @sgugger ?

Sep 20 '22 17:09 ArthurZucker

On it! 🤗

Sep 22 '22 16:09 ArthurZucker

Just added a test, RAG works, I think I'll try to test most of our models just to be sure that there is no other strange pattern.

Oct 13 '22 10:10 ArthurZucker

Tested with "openai/clip-vit-large-patch14", "xlm-roberta-base" in addition, works nicely.

Oct 14 '22 08:10 ArthurZucker