transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Add support for conditional detr

Open DeppMeng opened this issue 3 years ago • 2 comments

What does this PR do?

Added codes and documentations for conditioonal DETR model. The conditional DETR files are created by using the "add-new-model-like" feature of CookieCutter, based on DETR codes. All tests are passed. One thing I want to ask is that, I have converted the pretrained weights, how shoud I give these weights to you?

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case. https://github.com/Atten4Vis/ConditionalDETR/issues/21
  • [x] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

DeppMeng avatar Sep 09 '22 04:09 DeppMeng

The documentation is not available anymore as the PR was closed or merged.

The CI issue is caused by the fact that you have the following lines in src/transformers/models/auto/feature_extraction_auto.py:

("detr", "DetrFeatureExtractor"),
("detr", "DetrFeatureExtractor"),

=> this should be updated to:

("detr", "DetrFeatureExtractor"),
("conditional_detr", "ConditionalDetrFeatureExtractor"),

NielsRogge avatar Sep 21 '22 12:09 NielsRogge

Thanks a lot for all your work 🤗 merging!

NielsRogge avatar Sep 22 '22 07:09 NielsRogge