transformers icon indicating copy to clipboard operation
transformers copied to clipboard

[WIP] german docs translation

Open flozi00 opened this issue 3 years ago • 4 comments

What does this PR do?

Fixes # (issue)

Before submitting

  • [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline, Pull Request section?
  • [ ] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [x] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

@sgugger i am not sure about using "du / ihr" or "sie". "Du" is more personal, while "sie" is more formal

flozi00 avatar Aug 09 '22 14:08 flozi00

The documentation is not available anymore as the PR was closed or merged.

I think it's preferable to use the more formal option, but in most cases, I'd prefer to reformulate the sentences to use the first person plural (wir) unless the sentence actually describes an action the user has to take. We're using the same style for the French translation which also has two pronouns for "you".

sgugger avatar Aug 09 '22 14:08 sgugger

okay, then i will rewrite to "wir" and "sie"

At the moment its still mixed with du und sie

flozi00 avatar Aug 09 '22 14:08 flozi00

Let me know when you're done and thanks a lot for diving into German translation! (Sorry should have begun with that!)

sgugger avatar Aug 09 '22 14:08 sgugger

Thank you, @flozi00, for starting the German translation! 🤗 We created a new issue to track German translations (#18564).

@sgugger LGTM once the translation is done.

omarespejel avatar Aug 10 '22 19:08 omarespejel

ready to review @sgugger

flozi00 avatar Aug 11 '22 12:08 flozi00