transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Update state.best_metric after model evaluation; track metric for mod…

Open baskrahmer opened this issue 3 years ago • 4 comments

…el checkpointing separately in new state.best_metric_checkpoint variable

What does this PR do?

Fixes # (issue)

Before submitting

  • [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

baskrahmer avatar Jul 07 '22 14:07 baskrahmer

As suggested here: https://github.com/huggingface/transformers/issues/16620

baskrahmer avatar Jul 07 '22 14:07 baskrahmer

TODO: appropriate tests

baskrahmer avatar Jul 07 '22 14:07 baskrahmer

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Aug 06 '22 15:08 github-actions[bot]