hub-docs icon indicating copy to clipboard operation
hub-docs copied to clipboard

user info for git commits made in the hub

Open cceyda opened this issue 3 years ago • 10 comments

Is your feature request related to a problem? Please describe. When you create a model/dataset/space etc in the hub, or when you modify files, the git commits use the email you registered to the hub as your author email. to check: Just make a commit in the hub -> git pull -> git log.

This can be a privacy/security problem. Also makes it hard to mirror hub repos to github, as github throws security warning when you use a non public email in commits.

Describe the solution you'd like Would be nice if we could have a setting for a 'commit email'. Or the hub equivalent of "noreply.github.com"

Describe alternatives you've considered use throw away mail, not make commits in hub. not good workarounds.

wait is this it? can't get it to work with a noreply email though? image

cceyda avatar Jul 26 '22 07:07 cceyda

cc @osanseviero

LysandreJik avatar Jul 26 '22 07:07 LysandreJik

cc @SBrandeis

julien-c avatar Jul 26 '22 08:07 julien-c

For clarity @cceyda, which email address do you usually use in git command line? (presumably, you use a noreply one?)

julien-c avatar Jul 26 '22 08:07 julien-c

yes I use the noreply address given by github

cceyda avatar Jul 26 '22 08:07 cceyda

Ok so when pushing from git command line to huggingface you can similarly use [email protected] (and your commits will still be linked to your profile)

But it's not currently using that email address for commits generated from the website.

Also, it breaks the linking if you ever change your username

julien-c avatar Jul 26 '22 08:07 julien-c

I remember commit link breakage also happens on github if you change username. so [email protected] solution feels fine to me

cceyda avatar Jul 26 '22 09:07 cceyda

i think it used to break (on GitHub) but not anymore as they include your user (numeric) id now in the email

@abhishekkrthakur was affected by this BTW if i remember correctly

julien-c avatar Jul 26 '22 10:07 julien-c

thinking more about it users.noreply.huggingface.co addresses would also be un-linkable to the github accounts in case of mirroring etc. so maybe using a for commits only email address is the solution here. Allowing users to specify which address they want to use in their commits on the hub.

cceyda avatar Jul 26 '22 11:07 cceyda

fwiw, i ended up reverting my username :D

abhishekkrthakur avatar Jul 26 '22 11:07 abhishekkrthakur

(i would tend to tag this as low-priority as not many members have reported this use case)

julien-c avatar Jul 26 '22 11:07 julien-c