diffusion-models-class icon indicating copy to clipboard operation
diffusion-models-class copied to clipboard

Badges Update

Open dhakalnirajan opened this issue 2 years ago • 1 comments

In Readme.md:

  • License Badge added
  • Repository Fork Count Badge Added
  • Made With Jupyter Notebook Badge Added
  • Made With Pytorch Badge Added

dhakalnirajan avatar Nov 28 '22 13:11 dhakalnirajan

can we merge this already

kurbus avatar Dec 08 '22 14:12 kurbus

@lewtun what do you think? I hadn't merged because 1) not sure we want all the badges there (maybe at the end instead where they'll break the flow less) and 2) the format will likely change soon at which point these won't fit in anyway right?

johnowhitaker avatar Dec 09 '22 04:12 johnowhitaker

@johnowhitaker I think we can include them in the README since the migration to hf.co won't be affected. But I agree they could be placed in a better location. I think it's traditionally at the very top of the readme - WDYT?

lewtun avatar Dec 09 '22 16:12 lewtun

@johnowhitaker I think we can include them in the README since the migration to hf.co won't be affected. But I agree they could be placed in a better location. I think it's traditionally at the very top of the readme - WDYT?

Yeah, i could see that. But usually, badges are used to concentrate a lot of information into a small space, such as "This has the GNU GPL license" and "This uses PyTorch." By putting them at the start, this lets the readers know about it immediately, while putting it at the end makes it seem like a footnote, and a more descriptive sentence or two might perform better at the bottom, since as i mentioned above, badges are used for quick info

kurbus avatar Dec 09 '22 17:12 kurbus

@dhakalnirajan would you like to move these badges to the very top of the README? Then we can merge the PR :)

lewtun avatar Dec 11 '22 14:12 lewtun

@dhakalnirajan would you like to move these badges to the very top of the README? Then we can merge the PR :)

Sure. Give me few minutes. After that, I will PR it.

dhakalnirajan avatar Dec 11 '22 14:12 dhakalnirajan

Updated the badges to the top. :)

dhakalnirajan avatar Dec 11 '22 14:12 dhakalnirajan

Thank you :)

johnowhitaker avatar Dec 11 '22 14:12 johnowhitaker