diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Published 20 hours ago • verified publisher icon huggingface

[WIP] Add Apple M1 tests

Open anton-l opened this issue 3 years ago • 1 comments

testing things live, don't merge

anton-l avatar Oct 10 '22 16:10 anton-l

The documentation is not available anymore as the PR was closed or merged.

HuggingFaceDocBuilderDev avatar Oct 10 '22 16:10 HuggingFaceDocBuilderDev

@pcuenca the tests are ready for inspection right in this PR :)

Note: [MPSTemporaryNDArray initWithDevice:descriptor:] Error: product of dimension sizes > 2**31' outright segfaults, so we might not check all tests if the number of such failures is more than the number of pytest workers (4).

anton-l avatar Oct 11 '22 23:10 anton-l

Looks very cool ! Feel free to merge whenever @anton-l - also fine if they fail for a bit on master and we fix step-by-step

patrickvonplaten avatar Oct 14 '22 19:10 patrickvonplaten

Hi @anton-l !

I made a couple of changes:

  • Use the RC of the upcoming PyTorch 1.13.
  • Skip the test that crashed, added another one to test the attention layer that is compatible with MPS.
  • Skip some cuda tests on MPS.

However, AutoencoderKLTests.test_output_pretrained is still failing, I don't know the reason why.

Could you please take a look at my changes? I think we can merge with this one failure and I'll try to fix it in a couple days.

pcuenca avatar Oct 17 '22 18:10 pcuenca

Thank you @pcuenca, everything looks good!

anton-l avatar Oct 17 '22 18:10 anton-l