huggingface
WIP: talian translation: Chapter 3
@lewtun I am getting some issues with building the docs that I can't figure out. Can you help me out with this "Unexpected token" error? Thank you!
@lewtun the situation is made more complex by the fact that I am unable to reproduce the error locally, since the docs build without issue :(
Thank you @lewtun! It's been a lot of fun to translate chapter 3 :)
And sorry about the extra line, in hindsight I guess the "Unexpected token" error message was quite clear... But I would have never figured it out without your help!
Thank you for the great review @EdAbati !
@lewtun I've marked the PR as WIP in the hope that it won't be merged, please give me a couple of days to implement @EdAbati suggestions. I'll ping you when it's ready again.
Thank you again!
@lewtun I've marked the PR as WIP in the hope that it won't be merged, please give me a couple of days to implement @EdAbati suggestions. I'll ping you when it's ready again.
Sure! Maybe ping @lvwerra when you're as I'll be on vacation for the next couple of weeks :)
Hey @sharkovsky - I'm back from vacation, so happy to review this again whenever you're ready :)
Thank you @lewtun ! Please give me a couple more weeks as I'm currently on vacation , and unfortunately I haven't had a chance to implement @EdAbati 's suggestions !
Thank you @lewtun ! Please give me a couple more weeks as I'm currently on vacation , and unfortunately I haven't had a chance to implement @EdAbati 's suggestions !
No rush - enjoy your vacation 🤗
The documentation is not available anymore as the PR was closed or merged.
Hi @lewtun, I have implemented @EdAbati 's suggestions. (By the way, I had not realized what an epic re-reading effort you had made. Kudos for your attention to detail and thank you so much!)
On my end everything would be ready, but I see I'm failing an automatic check (not sure why). Maybe you could help me sort this out?
Thanks!
On my end everything would be ready, but I see I'm failing an automatic check (not sure why). Maybe you could help me sort this out?
Awesome work with integrating all the suggestions @sharkovsky ! I just ran make style to fix some code formatting and this should be good to merge once the CI is green
Thank you again!
@lewtun sorry to bother you, I noticed my name is missing from italian translators in the front-page README.md .... Is this intended? Thank you!