accelerate icon indicating copy to clipboard operation
accelerate copied to clipboard

Save config to hparams.yaml for Tensorboard tracker

Open nateraw opened this issue 3 years ago • 7 comments

Right now, it seems config is ignored when you accelerator.init_trackers(run, config) for Tensorboard tracker. Would be nice if the config is saved as hparams.yaml so it shows up in Tensorboard.

nateraw avatar Jul 13 '22 18:07 nateraw

Wdyt @muellerzr ?

sgugger avatar Jul 13 '22 20:07 sgugger

I think it makes sense to me, and still keeps in line with it being consistent throughout all the APIs for their respective trackers

muellerzr avatar Jul 13 '22 23:07 muellerzr

@muellerzr can I work on this?

Shreyz-max avatar Aug 16 '22 14:08 Shreyz-max

@Shreyz-max sure! 😄

muellerzr avatar Aug 16 '22 14:08 muellerzr

So, I did some research and found out that according to this issue, the HParams dashboard currently requires at least one hparam and at least one metric defined in the hparams configuration but according to this line here we are leaving the metric as empty. So, should I save the configs as a yaml file in the tracking.py file itself?

Shreyz-max avatar Aug 18 '22 17:08 Shreyz-max

@Shreyz-max that does seem like that'd be the way to do it then, so long as it can be shown in tensorboard correctly

muellerzr avatar Aug 18 '22 17:08 muellerzr

@muellerzr cool, thanks for the clarification. I'll complete it then.

Shreyz-max avatar Aug 18 '22 17:08 Shreyz-max