tide icon indicating copy to clipboard operation
tide copied to clipboard

Logger improvements

Open Fishrock123 opened this issue 5 years ago • 2 comments

Some minor follow-up for my previous change to the logger which made it use the debug formatter. Very helpful for debugging but probably annoying in "production-like" logs.

This also does some code deduplication.

I'd like to clean this up more but that probably means investing time in either changing the log format entirely or separating out the key-value formatter from log so that we can call it separately before passing to a log level.

Fishrock123 avatar Nov 03 '20 19:11 Fishrock123

error: component 'rustfmt' for target 'x86_64-unknown-linux-gnu' is unavailable for download for channel nightly
Sometimes not all components are available in any given nightly.
Error: Process completed with exit code 1.

Well that's fun. Maybe we should run fmt and clippy on beta and not nightly.

Fishrock123 avatar Nov 03 '20 19:11 Fishrock123

Well rustfmt is broken for over a week according to rust-toolstate, I haven't seen this before. Maybe we really need beta?

tirr-c avatar Nov 05 '20 06:11 tirr-c