node-html-to-text

node-html-to-text copied to clipboard

Not asking for a change but this patch broke the typescript type definitions test. The test has no format specified:

    tags: {
        a: {
            options: {
                hideLinkHrefIfSameAsText: true,
                linkBrackets: ["[", "]"],
            },
        },

This results in Error: Following selectors have no specified format: 'a'

It previously worked with the default format getting merged but that does not happen now. Also noting that in handleDeprecatedOptions there are a number of checks for the format value that may not have been set yet. Maybe needed a second call to mergeDuplicatesPreferLast after pushing all the tags to selectors.

Originally posted by @webstech in https://github.com/html-to-text/node-html-to-text/issues/249#issuecomment-1175597507

@webstech Thank you. I was going to keep the tags option in another version as it was deprecated relatively recently. So I'm going to address this in the next version (whatever that happens to be). The bug is currently present both in the master (v8) and in v9 branch. I should keep more tests for deprecated options.

I had to fix the issue with tags twice. It should work as intended now in version 9. To be finally removed in version 11, most likely.