laravel-friendships icon indicating copy to clipboard operation
laravel-friendships copied to clipboard

Published 20 hours ago • verified publisher icon hootlex

Physio patch 1

Open physio opened this issue 8 years ago • 3 comments

physio avatar Jan 14 '17 10:01 physio

Could you provide some tests ? And rebase your branch with the master branch ? Maybe rename the method getPendingFriendshipsCount or getPendingFriendRequestsCount. @hootlex, what you think about it ?

stephane-monnot avatar Apr 05 '17 15:04 stephane-monnot

hi, i can rename as you prefer, for me is the same.

physio avatar Apr 06 '17 06:04 physio

@stephane-monnot I think the most suitable name is getPendingFriendshipsCount.

@physio can you include a test case?

hootlex avatar Apr 08 '17 03:04 hootlex