htop icon indicating copy to clipboard operation
htop copied to clipboard

Solaris 11 compatibility

Open senjan opened this issue 6 years ago • 5 comments

This PR aims to address 2 issues with htop on current Solaris:

  1. htop does not build because Solaris's sys/sysinfo.h defines CPU_KERNEL which collides with definition within htop
  2. when run in a Non-Global Zone, kstat module "zones" is not available thus kstat_lookup() returns NULL making htop to crash due to NULL pointer dereference in SolarisProcessList_readZoneName().

senjan avatar May 27 '19 18:05 senjan

fixed missing symbol when building on Linux

senjan avatar May 30 '19 14:05 senjan

Thanks, @senjan - good catch. Keeping track of changes on both illumos and Oracle Solaris can be quite a chore. Contributions are always appreciated!

ghost avatar May 31 '19 12:05 ghost

is supporting an outdated OS really that important?

dodona2 avatar May 31 '19 15:05 dodona2

@dodona2 Solaris 11.4 is only nine months old. There are still pockets of industry users out there.

RobCrowston avatar Jun 06 '19 11:06 RobCrowston

Merged here: htop-dev/htop@b30c22d (though I renamed the somewhat cryptic "CPU_KRNL" to "CPU_SYSTEM")

natoscott avatar Aug 20 '20 04:08 natoscott