highlight.js icon indicating copy to clipboard operation
highlight.js copied to clipboard

Fixed highlight C++ std types in C

Open Dxuian opened this issue 1 year ago • 8 comments

Resolves #4103

added C lingo and rm C++ lingo

Checklist

  • [x] Added markup tests, or they don't apply here because...

Dxuian avatar Aug 30 '24 18:08 Dxuian

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

7 files changed

Total change +74 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +1 B
es/highlight.min.js 8.18 KB 8.18 KB +1 B
es/languages/c.min.js 1.97 KB 2 KB +34 B
es/languages/sql.min.js 2.44 KB 2.44 KB +1 B
highlight.min.js 8.22 KB 8.22 KB +2 B
languages/c.min.js 1.97 KB 2.01 KB +34 B
languages/sql.min.js 2.44 KB 2.44 KB +1 B

github-actions[bot] avatar Aug 30 '24 18:08 github-actions[bot]

Could we break this into two commits please, the first one just rewriting the keywords to be one per line (see some of the newer grammars), then the second actually making the changes - this way it's possible to review a diff and actually see what was changed - which is very difficult now.

I used to have a VS Code plugin for this but I think I've lost it.

joshgoebel avatar Aug 31 '24 18:08 joshgoebel

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

7 files changed

Total change +63 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB -2 B
es/highlight.min.js 8.18 KB 8.18 KB -2 B
es/languages/c.min.js 1.97 KB 2 KB +33 B
es/languages/sql.min.js 2.44 KB 2.44 KB +1 B
highlight.min.js 8.22 KB 8.22 KB -1 B
languages/c.min.js 1.97 KB 2.01 KB +33 B
languages/sql.min.js 2.44 KB 2.44 KB +1 B

github-actions[bot] avatar Sep 01 '24 00:09 github-actions[bot]

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +5 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +1 B
es/highlight.min.js 8.18 KB 8.18 KB +1 B
es/languages/sql.min.js 2.44 KB 2.44 KB +1 B
highlight.min.js 8.22 KB 8.22 KB +1 B
languages/sql.min.js 2.44 KB 2.44 KB +1 B

github-actions[bot] avatar Sep 01 '24 00:09 github-actions[bot]

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

7 files changed

Total change +72 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +1 B
es/highlight.min.js 8.18 KB 8.18 KB +1 B
es/languages/c.min.js 1.97 KB 2 KB +33 B
es/languages/sql.min.js 2.44 KB 2.44 KB +1 B
highlight.min.js 8.22 KB 8.22 KB +2 B
languages/c.min.js 1.97 KB 2.01 KB +33 B
languages/sql.min.js 2.44 KB 2.44 KB +1 B

github-actions[bot] avatar Sep 01 '24 00:09 github-actions[bot]

Could we break this into two commits please, the first one just rewriting the keywords to be one per line (see some of the newer grammars), then the second actually making the changes - this way it's possible to review a diff and actually see what was changed - which is very difficult now.

I used to have a VS Code plugin for this but I think I've lost it.

done but the order might still give you should i sort it add two commits for easier diffing also please review my other prs 🙏🙏 pr1 pr2 pr3

Dxuian avatar Sep 01 '24 00:09 Dxuian

@joshgoebel should i sort this alphabetically for easier diffing ?

Dxuian avatar Sep 29 '24 06:09 Dxuian

Could we break this into two commits please, the first one just rewriting the keywords to be one per line (see some of the newer grammars), then the second actually making the changes - this way it's possible to review a diff and actually see what was changed - which is very difficult now.

I used to have a VS Code plugin for this but I think I've lost it.

@joshgoebel or should i break up the whole thing into different lists for easier diffing ? (can you add hacktoberfest to the issue 🙏🙏🙏)

Dxuian avatar Oct 03 '24 05:10 Dxuian

To even review this this would need to only include the C changes, not all the SQL stuff.

joshgoebel avatar Oct 31 '24 22:10 joshgoebel

Closing for inactivity and multiple grammar changes in a single PR. This needs to be a PR from a branch with ONLY the C grammar changes. This can be reopened at any time you have the time to submit a new PR with isolated changes and address the questions asked.

joshgoebel avatar Dec 14 '24 15:12 joshgoebel