highlightjs
fixed css escape chars
Resolves #3965
(fixed the branch issue)
before
after
Checklist
- [x] Added markup tests, or they don't apply here because...
- [x] Updated the changelog at
CHANGES.md
Build Size Report
Changes to minified artifacts in /build, after gzip compression.
5 files changed
Total change +68 B
View Changes
| file | base | pr | diff |
|---|---|---|---|
| es/core.min.js | 8.18 KB | 8.18 KB | +1 B |
| es/highlight.min.js | 8.18 KB | 8.18 KB | +1 B |
| es/languages/css.min.js | 4.34 KB | 4.38 KB | +32 B |
| highlight.min.js | 8.22 KB | 8.22 KB | +2 B |
| languages/css.min.js | 4.35 KB | 4.38 KB | +32 B |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Build Size Report
Changes to minified artifacts in /build, after gzip compression.
5 files changed
Total change +56 B
View Changes
| file | base | pr | diff |
|---|---|---|---|
| es/core.min.js | 8.18 KB | 8.18 KB | -3 B |
| es/highlight.min.js | 8.18 KB | 8.18 KB | -3 B |
| es/languages/css.min.js | 4.34 KB | 4.38 KB | +32 B |
| highlight.min.js | 8.22 KB | 8.22 KB | -2 B |
| languages/css.min.js | 4.35 KB | 4.38 KB | +32 B |
Build Size Report
Changes to minified artifacts in /build, after gzip compression.
5 files changed
Total change +67 B
View Changes
| file | base | pr | diff |
|---|---|---|---|
| es/core.min.js | 8.18 KB | 8.18 KB | +1 B |
| es/highlight.min.js | 8.18 KB | 8.18 KB | +1 B |
| es/languages/css.min.js | 4.34 KB | 4.38 KB | +32 B |
| highlight.min.js | 8.22 KB | 8.22 KB | +1 B |
| languages/css.min.js | 4.35 KB | 4.38 KB | +32 B |
Build Size Report
Changes to minified artifacts in /build, after gzip compression.
5 files changed
Total change +130 B
View Changes
| file | base | pr | diff |
|---|---|---|---|
| es/core.min.js | 8.18 KB | 8.18 KB | +1 B |
| es/highlight.min.js | 8.18 KB | 8.18 KB | +1 B |
| es/languages/css.min.js | 4.34 KB | 4.41 KB | +63 B |
| highlight.min.js | 8.22 KB | 8.22 KB | +2 B |
| languages/css.min.js | 4.35 KB | 4.41 KB | +63 B |
Build Size Report
Changes to minified artifacts in /build, after gzip compression.
3 files changed
Total change +113 B
View Changes
| file | base | pr | diff |
|---|---|---|---|
| es/languages/css.min.js | 4.34 KB | 4.4 KB | +56 B |
| highlight.min.js | 8.22 KB | 8.22 KB | +1 B |
| languages/css.min.js | 4.35 KB | 4.41 KB | +56 B |
Build Size Report
Changes to minified artifacts in /build, after gzip compression.
2 files changed
Total change +112 B
View Changes
| file | base | pr | diff |
|---|---|---|---|
| es/languages/css.min.js | 4.34 KB | 4.4 KB | +56 B |
| languages/css.min.js | 4.35 KB | 4.41 KB | +56 B |
Build Size Report
Changes to minified artifacts in /build, after gzip compression.
5 files changed
Total change +75 B
View Changes
| file | base | pr | diff |
|---|---|---|---|
| es/core.min.js | 8.18 KB | 8.18 KB | -1 B |
| es/highlight.min.js | 8.18 KB | 8.18 KB | -1 B |
| es/languages/css.min.js | 4.34 KB | 4.38 KB | +38 B |
| highlight.min.js | 8.22 KB | 8.22 KB | +1 B |
| languages/css.min.js | 4.35 KB | 4.39 KB | +38 B |
Sorry for the delay. While coming back to this I just remembered that we support many CSS-like grammars - and many of those allow plain old CSS as well as their other syntactic improvements.
SO... to accept a css improvement you would also need to support:
- less
- stylus
- scss
There is a script to help with this.
- You'd first need to add a small representative sample set of escapes to
markup/css/css_consistency.txt...- with a paired result file...
- then use the
tools/cssscript -- which will copy the consistency test (as-is) into the
less,stylus, andscssfolders.
- which will copy the consistency test (as-is) into the
After that you need to work with the less, stylus, and scss grammars to get the markup tests passing - ie their on CSS output must exactly match the output of the CSS grammar.
Also perhaps look at the css_shared.js file, which might be useful for shared regex, etc.