go-otp icon indicating copy to clipboard operation
go-otp copied to clipboard

Published 20 hours ago • verified publisher icon hgfischer

Add support for SHA256 and SHA512

Open y3nr1ng opened this issue 9 years ago • 8 comments

Using a selector to choose between SHA1, SHA256 and SHA512. Hash algorithm is still default to SHA1.

y3nr1ng avatar Mar 21 '16 07:03 y3nr1ng

Thanks @liuyenting! But to merge it, could you please add some test new cases?

hgfischer avatar Mar 21 '16 17:03 hgfischer

Sure, but what's the criteria of the test? Do I have to extend the functions in the original test cases as well?

y3nr1ng avatar Mar 22 '16 02:03 y3nr1ng

Let's just keep the 100% test coverage. You can check with make cover.

hgfischer avatar Mar 22 '16 20:03 hgfischer

Hi @liuyenting

Do you still have the intent to fix the test coverage?

hgfischer avatar Apr 14 '16 13:04 hgfischer

Hi there... I'm facing my midterm right now, it's will be over in two weeks. Is it okay for me to patch this up at that time?

y3nr1ng avatar Apr 14 '16 13:04 y3nr1ng

Sure. :)

On 14 April 2016 at 15:47, Liu Yen-Ting [email protected] wrote:

Hi there... I'm facing my midterm, it's will be over in two weeks. Is it okay for me to patch this up at that time?

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/hgfischer/go-otp/pull/5#issuecomment-209950808

hgfischer avatar Apr 14 '16 20:04 hgfischer

The proposal is still up. ;)

hgfischer avatar Jul 28 '17 19:07 hgfischer

Uh oh... I've completely forgotten about this, gonna look into this immediately! Lucky me, summer vacation in progress.

y3nr1ng avatar Jul 30 '17 14:07 y3nr1ng