terraform-provider-heroku icon indicating copy to clipboard operation
terraform-provider-heroku copied to clipboard

Support for Docker apps deployed with Container Registry

Open eliasdorneles opened this issue 6 years ago • 4 comments

Hello!

Is there a plan to add support for Dockerized apps deployed with the Heroku Container Registry ?

I'm currently working on automating the creation of Heroku apps which use this deployment method (namely, with stack = container, no usage of buildpacks, there are no builds happening in Heroku side) and I'm evaluating what are the possibilities.

I'm currently considering forking this provider to adapt it to my needs and maybe contributing upstream if I arrive at something reusable. I haven't found anything about this in older issues, so I'm opening this to start a discussion.

eliasdorneles avatar May 29 '19 14:05 eliasdorneles

Currently, building from a Dockerfile is the only Docker container workflow supported by this Terraform provider. See: heroku_build resource.

Releasing an existing container image is only available in the pre-release Heroku API docker-releases variant. We will not implement this in heroku_formation resource, until it's moved into the stable, generally available Platform API. (I don't know when, if ever, that will happen.)

mars avatar May 29 '19 20:05 mars

For those that are interested, I've implemented docker container release support for my the herokux provider.

davidji99 avatar Jan 11 '21 03:01 davidji99

Too bad, this would be really helpful to have! I tried using this provider with supported approach, which is heroku.yml and then Heroku builds the image for us -> but building such image is really slow, in my case it takes 7 minutes for something that on my machine gets built in a minute! So having an option to push Docker image would be amazing. I understand that it is not yet part of stable API, maybe it could also be marked as experimental/non-stable feature here in this provider?

Martinsos avatar Jan 29 '21 09:01 Martinsos

Hi @Martinsos,

This provider will not implement any resources using APIs that are not part of the Platform API. See previous comments by the maintainer(s) on this topic.

davidji99 avatar Feb 01 '21 01:02 davidji99