helix

helix copied to clipboard

Shows number of open files and index of the one currently viewed.

Hmm I think we could come up with a better name for it. Indexer sounds like a background service that indexes files

Maybe file_counter would be more fitting or do you have an idea?

FileNumber or FileCount would make sense to me. I think we should avoid naming things with agent nouns (indexer, counter) except where there's a lot of precedent for it (picker, receiver, server)

I'd go with FileCount then, if that's ok!?

What is the preferred way to do this? Change the existing pr, which would make the discussion about the name kinda pointless, or make a new one? I'm pretty new to git and github so i'm realy not sure.

What is the preferred way to do this? Change the existing pr, which would make the discussion about the name kinda pointless, or make a new one? I'm pretty new to git and github so i'm realy not sure.

Feel free to commit and push additional commits to apply the suggestions. Unless you push force, original commit history will stay available from this PR. That being said, it’s generally okay to just push force if you wish to get the commits merged as is. If history is not "clean", maintainers will just squash and merge as necessary, so feel free to proceed as you prefer in this case. :slightly_smiling_face:

Hey, I was wondering if I have to change something else, request a review or is this better suited as a plugin once the system is in place maybe?

I am going to close this one out as stale since the statusline has been refactored. I think this one is a bit niche and better suited for a plugin. Sorry we didn't give you that feedback sooner and thank you for contributing!