helix icon indicating copy to clipboard operation
helix copied to clipboard

Published 20 hours ago • verified publisher icon helix-editor

feat(core): add plaintext matching fallback to tree-sitter matching

Open alevinval opened this issue 3 years ago • 1 comments

This patch introduces bracket matching independent of tree-sitter grammar. For the initial iteration of this feature, only match on the current line. This matching is introduced as a fallback in cases where the tree-sitter matcher does not match any bracket.

This fallback should provide a better experience to users that are editing documents without tree-sitter grammar, but also provides a better experience in cases like the ones reported in #3614

If we find that this feature works well, we could consider extending it for multi-line matching, but I wanted to keep it small for the first iteration and gather thoughts beforehand.

Relates to #3584 as well

alevinval avatar Oct 15 '22 09:10 alevinval

Let me know your thoughts about this.

alevinval avatar Oct 15 '22 09:10 alevinval

hi, any progress here possible?

workingj avatar Jan 26 '23 23:01 workingj

@archseer thoughts on this PR?

alevinval avatar Feb 26 '23 21:02 alevinval

Folks! I've been out of the loop for some time. I got back into this, I've rebased latest master to make sure everything kept working, the pending feedback that was requested has been applied in: https://github.com/helix-editor/helix/pull/4288/commits/adf0fbd3c8a663ceeaba3050f955c4bdec242381 https://github.com/helix-editor/helix/pull/4288/commits/715b928dae00d8048f32ce8c6527a9d45f7d4f70 and https://github.com/helix-editor/helix/pull/4288/commits/f5cb382af064d6db6df2e5da89913ae24e363ee5

alevinval avatar Jun 01 '23 14:06 alevinval