helix

helix copied to clipboard

The implementation provides a hard-coded limit of 3 restarts per LSP stored at Client. On each restart it basically reduces the counter and spawns a job for starting LSP.

Resolves #6398

Why did you move clients out of registry? The registry is supposed to be exactly that a list/registry of all lsp "clients"

It's still in the registry and the same mod. The two parts: the clients themself and the structures dependent on them. I would consider the refactored version seems way cleaner (in terms of more obvious invariants) and harder to make a mistake (e.g forget to add to name list). Though if disagree I may revert that, no problem

The Registry type is already pretty small and self contained so I don't think we need a refactor like this. In general you should try to avoid making refactors that aren't crucial to make the end change, it just makes the changes harder to review.

Sure, pushed a minimized patch