vscode-drawio icon indicating copy to clipboard operation
vscode-drawio copied to clipboard

Feature request: match theme colors

Open onlyafly opened this issue 5 years ago • 6 comments

Great extension. It just works :)

As you can see below, the colors of the extension don't match the theme colors. It would be awesome if it did!

Screen Shot 2020-05-10 at 18 11 33

onlyafly avatar May 10 '20 16:05 onlyafly

I tried to match at least the dark/light-mode. However, there seems to be a bug in VS Code that prevents that.

However, matching the actual colors is a daunting (but not impossible) task. I don't think I'm going to implement that by myself but I'm open for contributions!

hediet avatar May 10 '20 16:05 hediet

Would it be possible to make light/dark configurable? I use dark mode for my editor, but want to see how my figure would appear against white background since my figure will eventually be on a white background.

EntilZha avatar May 11 '20 02:05 EntilZha

Or maybe just use the drawio themes ?

Fr33maan avatar May 11 '20 05:05 Fr33maan

There is a config option now in v0.3.0. This option lets you choose a Draw.io theme independently of VS Code's active theme.

hediet avatar May 11 '20 19:05 hediet

For set light theme, add in your settings.json next:

    "hediet.vscode-drawio.theme": "atlas"
    // or if you'd like white menu on the top, not blue, use "Kennedy" theme
    "hediet.vscode-drawio.theme": "Kennedy"
    // or if you mostly view, not edit, use "minimal" theme 
    "hediet.vscode-drawio.theme": "min"

Dark:

    "hediet.vscode-drawio.theme": "dark"
Screenshot Examples (click to show)
  • atlas: atlas
  • Kennedy: Kennedy
  • min: min
  • dark: dark

Possible values: https://github.com/hediet/vscode-drawio/blob/6d8bba36feb0fc1039e89571f32ee3e969f7f579/package.json#L85-L89

MaxymVlasov avatar May 12 '20 14:05 MaxymVlasov

The settings are a great solution, imho matching theme colors would be overkill

EntilZha avatar May 15 '20 01:05 EntilZha