react-multi-select-component icon indicating copy to clipboard operation
react-multi-select-component copied to clipboard

When press Select All(Filtered) button, the previously selected value is deselected.

Open jung0han opened this issue 3 years ago • 6 comments

Describe the bug When using the Custom Filter option, search for keywords, and press Select All(Filtered) button, the previously selected value is deselected.

https://react-multi-select-component.pages.dev/iframe?id=custom-filter--example-custom-filter&args=&viewMode=story

To Reproduce Steps to reproduce the behavior:

  1. Select any value.
  2. Search by specific keyword.
  3. Click Select All (Filtered).
  4. The previously selected value is deselected and only the filtered value is selected.

Expected behavior The previously selected value remains and the filtered value is added.

Screenshoot Hnet-image

jung0han avatar Mar 12 '22 07:03 jung0han

Thanks I'll take a look

harshzalavadiya avatar Mar 14 '22 06:03 harshzalavadiya

@jung0han Are you sure that it is actually being de-selected or does it just look that way. Since "R5-D4" appears later in the list, I suspect that it is just not showing up in list of selected items, and the json there is being cut-off. I would like to see what happens when you type "R5-D4" in the search. I suspect it will be there and checked.

MegaKeegMan avatar May 27 '22 19:05 MegaKeegMan

@jung0han Are you sure that it is actually being de-selected or does it just look that way. Since "R5-D4" appears later in the list, I suspect that it is just not showing up in list of selected items, and the json there is being cut-off. I would like to see what happens when you type "R5-D4" in the search. I suspect it will be there and checked.

@MegaKeegMan Unfortunately when I search for "R5-D4" again, it's deselected.

jung0han avatar Jun 08 '22 00:06 jung0han

@MegaKeegMan already fixed? i can commit if not

koshpendi avatar Jul 30 '22 15:07 koshpendi

@koshpendi thanks and go ahead. I realize I had actually misread this issue back when I commented and can easily reproduce this bug. I have not written any fix.

MegaKeegMan avatar Jul 30 '22 15:07 MegaKeegMan

can't fin this problem in this example. code sandbox example

Shorifpatwary avatar Dec 28 '22 10:12 Shorifpatwary