Eliza Weisman

Results 571 comments of Eliza Weisman

@pcwalton I've been working on bringing the current UI more in line with your proposal. Here's what I've got so far: ![image](https://user-images.githubusercontent.com/2796466/129491295-124902c0-af15-4223-9275-416138aeaadc.png)

getting closer! ![image](https://user-images.githubusercontent.com/2796466/129774370-854f083e-2cf5-44d4-80a9-5a201e6f77d1.png)

I believe @zaharidichev previously added instrumentation to the Tokio MPSC channels, but it had to be removed because the `console-subscriber` crate uses a MPSC internally, so it caused a deadlock....

(the problem is specifically the `register_callsite` calls for the MPSC instrumentation causing the use of a MPSC channel. we could probably work around this by special casing those callsites to...

@domodowyer > I've also run into the deadlock you describe when switching `console-subscriber` to use the `tokio` patched to emit the spans too. Two attempts are made to acquire the...

Over what time interval was the memory leak observed, and does it eventually become stable? I'm wondering about this because it's possible what you're seeing is not actually a memory...

I agree that authentication is important if enabling the console in production. However, I think it seems out of scope for the `console-subscriber` crate _itself_ to implement the authentication mechanism(s)....

> * Basic security should probably be turned on by default (`console_subscriber::init()`) to not end up with log4shell-style situation. I agree that we should offer some security by default when...

Honestly, I'm not totally sure how important having a default authentication mechanism is, as I imagine most users deploying console-enabled software in prod won't use whatever scheme we provide by...

There's still the question, though, of what authentication mechanisms the console CLI needs to support...and since we _have_ to actually support them in the CLI, we may as well have...