gitkube icon indicating copy to clipboard operation
gitkube copied to clipboard

change naming schema for the username and group

Open majodev opened this issue 7 years ago • 2 comments

Hi,

It seems like naming a remote is subject to certain limitations as groupadd is executed (potentially 32chars?).

Example

apiVersion: gitkube.sh/v1alpha1
kind: Remote
metadata:
  name: app-remote
  namespace: my-really-really-really-long-ns
k logs po/gitkubed
Setting up git remotes
Configuring : my-really-really-really-long-ns-app-remote
Adding user `my-really-really-really-long-ns-app-remote' ...
Adding new group `my-really-really-really-long-ns-app-remote' (1000) ...
groupadd: 'my-really-really-really-long-ns-app-remote' is not a valid group name
adduser: `/usr/sbin/groupadd -g 1000 my-really-really-really-long-ns-app-remote' returned error code 3. Exiting.

Is there any way to overwrite the computed my-really-really-really-long-ns-app-remote identifier so groupadd can run through?

majodev avatar Jul 23 '18 16:07 majodev

Yeah, I suppose there will be a problem with really long ns + remote names. Good catch. Maybe we can use some hash to represent (the user and groups) internally. I will send a fix soon.

tirumaraiselvan avatar Jul 23 '18 17:07 tirumaraiselvan