vault adding non-nil validation check before caching an entry.

adding non-nil validation check before caching an entry.

Open alekhrj opened this issue 2 years ago • 3 comments

Fixes: https://github.com/hashicorp/vault/issues/18251

Signed-off-by: Alekh Raj [email protected]

Dec 07 '22 07:12 alekhrj

@alekh2 is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

Dec 07 '22 07:12 vercel[bot]

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

_{Have you signed the CLA already but the status is still pending? Recheck it.}

Dec 07 '22 07:12 hashicorp-cla

Caching the absence of a storage entry is a valid thing to do, to prevent needing to re-check its absence with the storage backend later. See #18251 for further discussion.

Dec 12 '22 22:12 maxb

As @maxb mentioned, this is expected and documented behavior, so I'll go ahead and close this PR now. Thanks!

Jan 24 '23 00:01 heatherezell

vault vault copied to clipboard

adding non-nil validation check before caching an entry.

vault
vault copied to clipboard