terraform-provider-azurestack

terraform-provider-azurestack copied to clipboard

Add support to create a custom virtual machine image that can be used to create virtual machines.

Quick question is this work in progress or we have some new direction, this is something definitely required, every vm/vmss cannot be booted from a platform image.

Somehow the code to make this work is already in the provider source code. I removed the comments on the code and tested that it will properly deploy VMs based on custom images. Not sure why this was left commented out.

I did not notice any other side effects. I created a pull request to fix this issue:

https://github.com/terraform-providers/terraform-provider-azurestack/pull/117

And if you are curious on how to make use of the custom image feature here is a link to a module I wrote that deploy with a custom image:

https://github.com/canada-ca-terraform-modules/terraform-azurestack-basicwindowsvm-customimage

Not sure what is going on. Pull request appear to be stuck at Travis step... but travis validation is completed...

How do we get this pull request unstuck?

We need this feature enabled. If you try to create VM from custom image it will complain that publisher is missing. This is verified and it is working.

I really hope they can merge that in a soon to be released update... But this project is strangely quiet.

This is still ignored?!? @katbyte

I am losing faith in this provider... not much is being done and Azurestack support in terraform is really falling behind... to a point where it is less and less interesting to us.

I'll see if I can get the team to get some eyes on the PR, sorry about the wait! 😄

Guess this is not going to happen.

I'm starting to think this project is actually abandoned. If so, it should be marked as such. It's borderline unusable with several major omissions(with this issue being one of the biggest offenders). Contributing to it doesn't sound like a good proposition since commits languish in PR hell. Which is mind blowing, as the proposed PR looks exactly the same as the code that already exists in AzureRM which was inexplicably commented out.

Interestingly, I found a reference to this non-existing feature (azurestack_image) while looking at another issue – which turns out to be exactly the same as this, just on a different resource (https://www.terraform.io/docs/providers/azurestack/r/virtual_machine_scale_set.html#example-of-storage_profile_image_reference-with-id) It's clear that whoever wrote this never tried the code and just did a find/replace on the AzureRM documentation.

Regardless of the existence of the azurestack_image (resource / data source), a custom image ID doesn't work for VMSS either. As it is, the provider does check the ImageID but then does absolutely nothing with it and sends garbage to the API (https://github.com/terraform-providers/terraform-provider-azurestack/blob/bfc4ad441f5602b9bc7ddd19d655dce5741b29e8/azurestack/resource_arm_virtual_machine_scale_set.go#L1599).

This is in contrast to AzureRM which actually does the right thing (https://github.com/terraform-providers/terraform-provider-azurerm/blob/ae1b4d6994726eef21299e674220c48c8917c7c7/azurerm/internal/services/compute/resource_arm_virtual_machine_scale_set.go#L2115)

IMHO the provider should be rewritten, deprecated or we should be able to use the azurerm provider directly on azure stack (knowing some parts won't work as api are behind and most of resources unavailable)