terraform-provider-azurerm icon indicating copy to clipboard operation
terraform-provider-azurerm copied to clipboard

CDN FrontDoor: support for Firewall Policies

Open sanderobdeijn opened this issue 4 years ago • 3 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The new Azure Frontdoor premium #11983 also uses a different waf SKU. The rest of the waf config seems to be same. There are now 3 sku's:

  • Classic_AzureFrontDoor (default)
  • Premium_AzureFrontDoor
  • Standard_AzureFrontDoor

New or Affected Resource(s)

  • azurerm_frontdoor_firewall_policy

Potential Terraform Configuration

resource "azurerm_frontdoor_firewall_policy" "example" {
  name                = "example"
  resource_group_name = azurerm_resource_group.rg.name
  enabled                           = true
  mode                              = "Prevention"
  sku                   = "Premium_AzureFrontDoor"
}

References

https://docs.microsoft.com/en-us/rest/api/frontdoorservice/webapplicationfirewall/policies/create-or-update#sku

sanderobdeijn avatar Oct 21 '21 20:10 sanderobdeijn

Hoi @sanderobdeijn! I have taken a short look, but it isn't as easy as adding a variable.

This requires a new API release for Azure FrontDoor, requested here

aristosvo avatar Oct 22 '21 11:10 aristosvo

@mbfrahry any chance you could look into switching FrontDoor over to an Embedded SDK?

tombuildsstuff avatar Oct 22 '21 15:10 tombuildsstuff

@mbfrahry It says #14093 supercedes this issue. And since #14093 has been merged should this be fixed? I tried to set a SKU but couldn't find a setting in the documentation.

sanderobdeijn avatar Dec 01 '21 21:12 sanderobdeijn

This functionality has been released in v3.26.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] avatar Oct 11 '22 19:10 github-actions[bot]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Nov 11 '22 02:11 github-actions[bot]