design-system icon indicating copy to clipboard operation
design-system copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

`AppFooter` - Convert to Typescript

Open Dhaulagiri opened this issue 1 year ago • 2 comments

:pushpin: Summary

Converts the AppFooter component to TS

:link: External links

Jira ticket: HDS-2682

Dhaulagiri avatar May 15 '24 16:05 Dhaulagiri

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview May 20, 2024 2:07pm
hds-website ✅ Ready (Inspect) Visit Preview May 20, 2024 2:07pm

vercel[bot] avatar May 15 '24 16:05 vercel[bot]

Once https://github.com/hashicorp/design-system/pull/2108 lands I'll make similar adjustments here, but for now it'd be good to get more feedback on everything else besides those details

Dhaulagiri avatar May 16 '24 20:05 Dhaulagiri

I took the liberty of pushing a tiny commit (instead of adding it as a suggestion. The definition for Element is usually the outermost/root element in the file, but if splattributes are used on another element then that element becomes the Element (and the outermost/root element is considered as some sort of a wrapper).

alex-ju avatar May 17 '24 17:05 alex-ju

I believe I addressed all the feedback at this point and rebased to pickup the upstream changes to the template registry

Dhaulagiri avatar May 17 '24 18:05 Dhaulagiri