consul

consul copied to clipboard

Description

Closes #11046 (though ideally want to confirm with the originally poster of that enhancement request)

Previously, to perform tag-based filtering with an RFC 2782 style DNS lookup, the tag needed to be specified in the RFC 2782 protocol field. Some external systems require the protocol field to specify the protocol (e.g., TCP) and do not allow using an arbitrary value (e.g., service tag).

This commit allows the tag to be specified separately from the protocol field:

_<service>._tcp.<tag>.service[.<datacenter>].<domain>

I confirmed the utility of this change with original issue poster (refer to this comment).

Testing & Reproduction steps

See new unit tests

PR Checklist

• [x] updated test coverage
• [x] external facing docs updated
• [x] not a security concern

@boruszak : thanks for the feedback! I merged the other DNS-related PR so this docs diff is now much smaller. I've incorporated your feedback.

Thanks @jkirschner-hashicorp! I just took another look and everything LGTM. Looks like you're all set to merge - LMK if you'd prefer I take over on merging!

@boruszak : don't merge this. The eng team needs to review the code changes first. Thanks for the second pass though!

I'll merge after eng has reviewed and approved.

Still need an engineering review

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.