pytorch-struct icon indicating copy to clipboard operation
pytorch-struct copied to clipboard

Published 20 hours ago • verified publisher icon harvardnlp

Value expectation and 1st order CKY

Open teffland opened this issue 4 years ago • 4 comments

Changes are:

  • Add 1st order cky implementation with suggested updates
  • Add value-expectation semiring and test
  • Make marginal computation work on potentials w/o gradients
  • Minor clarity/consistency changes to semirings
  • Some documentation for _Struct

teffland avatar Jan 20 '21 17:01 teffland

Hmm, for some reason the tests are not running on this. Trying to figure out why.

srush avatar Jan 20 '21 18:01 srush

Thanks the PR. Lots of nice stuff in here.

srush avatar Jan 20 '21 19:01 srush

Quick dev question: when I try running python setup.py test or python setup.py style, I get error: invalid command 'tests' and error: option --ignore not recognized, respectively. I can run the command on their own, but I'm just wondering if I'm doing something wrong?

teffland avatar Jan 22 '21 15:01 teffland

Interesting, yeah not sure how to run those automatically, I will look into it.

srush avatar Jan 22 '21 16:01 srush