Hajnal Máté

Results 40 comments of Hajnal Máté

@JesseStutler Anytime, I needed to duble check twice that it's not you😀

Superb! The approach looks good. Thank you for picking this up.

This PR would solve the issue too: https://github.com/volcano-sh/volcano/pull/4662

Whao, this is a neat feature idea. I would happily collaborate on this 👍

This is not true. You can set it to any value. We only set it to the cluster capacity when it's empty. https://github.com/volcano-sh/volcano/blob/master/pkg/scheduler/plugins/capacity/capacity.go#L590 Aren't you using an old version or...

Oh sry, I understand it now. We want to overwrite the realCapability with the root Queue's capability, maybe renaming it to overwriteRootQueueRealCapability would better reflect the intention and logic behind...

It looks like this would solve other issues too: [https://github.com/volcano-sh/volcano/issues/4684](https://github.com/volcano-sh/volcano/issues/4684) Do you need any help with this PR? If you don't have enough time I can polish this quite fast...

/ok-to-test @mrendi29 Anytime! 👍 Sorry that this got out of my focus. One thing that came to my mind regarding the error you got, is that you shouldn't send pods...