BD-AutoScroll icon indicating copy to clipboard operation
BD-AutoScroll copied to clipboard

Published 20 hours ago • verified publisher icon hackermare

Potential problems found

Open Strencher opened this issue 2 years ago • 1 comments

First of all, this Switch component should be cached so it doesn't do a webpack search every time you open the settings panel.

https://github.com/hackermare/BD-AutoScroll/blob/41fc59c9d0c2b55160156330e1624660ad02e6ea/AutoScroll.plugin.js#L81

Secondary, you should add better error handling because components like Switch, Slider and so on can change at any time and cause your settings panel to crash.

Strencher avatar Dec 18 '22 20:12 Strencher

I fixed the first problem. I'm not sure what you want me to do with the second one though. Just not show anything on the settings panel if the components are missing? I think the error message would be more useful...

hackermare avatar Feb 20 '23 17:02 hackermare