noscript icon indicating copy to clipboard operation
noscript copied to clipboard

Req: Dark mode

Open Jonta opened this issue 5 years ago • 9 comments

I use the dropdown to enable scripts the most, I assume other users do too, so if incremental, I suggest starting there, before moving on to the settings-screen and the high contrast mode

Jonta avatar May 16 '20 23:05 Jonta

Any update on this?

demostanis avatar May 27 '21 10:05 demostanis

Are there any other popular/recommended extensions around implementing dark-mode, as a template to follow? (just checked uBlock and HTTPS Everywhere, they don't).

hackademix avatar May 27 '21 10:05 hackademix

uBlock supports dark mode in dev builds. CanvasBlocker supports a dark mode too.

demostanis avatar May 27 '21 10:05 demostanis

In lib/theme.js, CB uses

if (window.matchMedia("(prefers-color-scheme: dark)").matches){
     theme = "dark";
}

to know whether it should be dark or not.

demostanis avatar May 27 '21 10:05 demostanis

Tab Session Manager is another good example for a well implemented dark mode of an extension.

anmutech avatar Jun 09 '21 22:06 anmutech

Any update on this?

demostanis avatar Jul 10 '21 07:07 demostanis

This should be closed because dark mode has been added with the new UI changes image

Felipe9999 avatar Mar 25 '22 23:03 Felipe9999

Yes, but buttons in the top row are still light when High contrast is checked.

noscript_dark

ynakao avatar Mar 26 '22 00:03 ynakao

Yes, but buttons in the top row are still light when High contrast is checked.

noscript_dark

I think that's somehow related with high contrast being - as its name implies - high contrast. Still, would be a nice UI change request for those boxes to be dark as well. On my comment, however, I was referring to the normal dark mode, not high contrast mode with dark theme

Felipe9999 avatar Mar 26 '22 01:03 Felipe9999