gir icon indicating copy to clipboard operation
gir copied to clipboard

Fix or remove config split_build_rs

Open EPashkin opened this issue 5 years ago • 4 comments

As it not used with crate system_deps.

It was added in #915, @kinnison @sdroege Seems now it need be "generate_build_rs = false" instead of "split_build_rs=true" at minimum in gdk-sys

EPashkin avatar Jul 25 '20 12:07 EPashkin

We added this so that we'd stop rewriting the bits of build.rs which dealt with gdk backends. If the new system_deps stuff avoids that generated content entirely then that seems reasonable to me. However my context is otherwise pretty much vanished on this, so I'm not sure I can be much more help.

kinnison avatar Jul 27 '20 08:07 kinnison

That's still in gdk-sys and needs to stay there.

sdroege avatar Jul 27 '20 09:07 sdroege

@sdroege But now we don't needed build_version.rs so IMHO better rename option

EPashkin avatar Jul 27 '20 16:07 EPashkin

That's true :)

sdroege avatar Jul 27 '20 16:07 sdroege