go-grpc-middleware

go-grpc-middleware copied to clipboard

Fix grpc middleware interceptor not PostCall-ing when a streaming RPC with non-streaming server finishes successfully.

1

Current Client-side Stream Interceptor implementation is bugged - it assumes that if the RPC is streaming, then the Server must be streaming responses too. This is incorrect, as a Streaming...

alexandrupitis1

Retry-Middleware: allow smart retry with suggestion from server

2

Hi, is there a plan for supporting retry middleware with minimum retry wait duration. For example, when the server return RetryDelay struct [RetryInfo](https://pkg.go.dev/google.golang.org/genproto/googleapis/rpc/errdetails#RetryInfo) the client can use this information to...

ducttse

Add two labels grpc_server_ip and grpc_client_ip to the server metrics when option WithServerIPLabelsEnabled() is set. These labels are not added by default for compatibility. This pr proposes an implementation for...

diabloneo

CI keeps failing

2

**Go version used**: n/a **What happened**: https://github.com/grpc-ecosystem/go-grpc-middleware/actions/runs/12800384294/job/35688069659 ``` Run make lint make lint shell: /usr/bin/bash -e {0} env: GOROOT: /opt/hostedtoolcache/go/1.21.13/x64 (re)installing /home/runner/go/bin/buf-v1.26.1 go: downloading github.com/bufbuild/buf v1.26.1 ... (re)installing /home/runner/go/bin/goimports-v0.7.0 ......

bkane-msft

The execution order of otelgrpc.StreamClientInterceptor() and otelgrpc.NewClientHandler() has changed.

1

After otelgrpc.StreamClientInterceptor() was deprecated, it is recommended to replace it with otelgrpc.NewClientHandler(). However, the execution order is different: interceptors run first, followed by StatsHandlers. From the code, this seems to...

b-anastasiia

Interceptors not compatible with log/slog.Default()

1

The current implementation is not compatible with the std library `log/slog` package https://github.com/grpc-ecosystem/go-grpc-middleware/blob/main/interceptors/logging/logging.go#L188-L196 The compiler error is ``` have Log(context.Context, slog.Level, string, ...any) want Log(context.Context, logging.Level, string, ...any) ``` **Go...

simone-dimaulo-hs

AttemptMetadataKey = "x-retry-attempt" in retry StreamClientInterceptor

3

Hi, Is it possible add AttemptMetadataKey = "x-retry-attempt" https://github.com/grpc-ecosystem/go-grpc-middleware/blob/main/interceptors/retry/retry.go#L22 in StreamClientInterceptor ? exactly the same way it works in UnaryClientInterceptor thank you

Boklazhenko